search

upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io
8 stars 41 forks source link

Automatically remove todo item with no content #40

Closed samyakvaidya10 closed 1 year ago

samyakvaidya10 commented 1 year ago

This PR fixes issue no. 37 .

https://user-images.githubusercontent.com/99262565/194704157-ce8cbfde-cfc7-49b4-b2ca-c756724af59b.mp4

kamalkishor1991 commented 1 year ago

@samyakvaidya10 it should only get removed if back button is pressed and also it back button is pressed with text the text should merge with previous item.

kamalkishor1991 commented 1 year ago

@samyakvaidya10 closing this because of lack in activity. Please create a new PR or reopen if you are still working on this.

samyakvaidya10 commented 1 year ago

@samyakvaidya10 closing this because of lack in activity. Please create a new PR or reopen if you are still working on this.

I apologize for showing a lack of inactivity and not giving a response.

@samyakvaidya10 it should only get removed if back button is pressed and also it back button is pressed with text the text should merge with previous item.

In the last few days, I'm clearing my basic concepts of react and still I'm not sure if ill be able to solve this issue. I'll open a new pr when I come up with some solution. Thanks.

kamalkishor1991 commented 1 year ago

@samyakvaidya10 no issues. Good luck 👍