upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io
8 stars 41 forks source link

Feature/undo redo #56

Closed shahanahmed86 closed 11 months ago

shahanahmed86 commented 11 months ago
kamalkishor1991 commented 11 months ago

@shahanahmed86 thanks a lot for the pull request. I will review it in few days.

shahanahmed86 commented 11 months ago

@shahanahmed86 thanks a lot for the pull request. I will review it in few days.

@kamalkishor1991 this is my first contribution to the open-source community and I am not an expert on team collaboration and GITOPS things. If you found anything that I need to work on then please suggest me.

shahanahmed86 commented 11 months ago

@kamalkishor1991, I've updated the pull request with all conflicts resolved and deployed the app on this URL. Please check the demo also before merging.

kamalkishor1991 commented 11 months ago

I found 2 issues.

  1. The action bar width should match Screenshot 2023-05-28 at 1 44 41 PM

    the bottom area

  2. When adding more items the add item is merging with action bar. Please check
shahanahmed86 commented 11 months ago

@kamalkishor1991, The changes that you ask to fix are now updated in the last commit:

kamalkishor1991 commented 11 months ago

Thanks @shahanahmed86 for the PR and taking care of all the review comments.