Missing Components - Githubissues

upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io

8 stars 41 forks source link

Missing Components #57

Closed shahanahmed86 closed 9 months ago

shahanahmed86 commented 11 months ago

I think there are below-mentioned things that need to be implemented:

prettier
eslint integrated with airbnb standard
husky as a pre-commit hook that'll call lint-staged scripts
lint-staged that will check prettier, then linting, and then proceed with the commit
unit testing with jest
e2e testing with cypress

airbnb is a suggestion

kamalkishor1991 commented 11 months ago

@shahanahmed86 this is a great list. Really appreciate if you could create PR for some of these. Basic linting support is already there and jest was also added with only few tests. We need to add lot more tests.

Sukhacoder02 commented 9 months ago

@kamalkishor1991 Can I take this up?

shahanahmed86 commented 9 months ago

@kamalkishor1991 Can I take this up?

I really got busy since I opened the issue. You can take it up

Sukhacoder02 commented 9 months ago

I have raised a PR for the same with few of the above things.