search

upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io
8 stars 41 forks source link

Dragdrop #6

Closed mkirvan00 closed 1 year ago

bhujoshi commented 2 years ago

@mkirvan00 Thanks for spending time working on this feature. I have checked it. And drag and drop working pretty fine. But I can see a few gaps in the current implementation. And I feel that it is completely my fault because the ticket did not contain enough information. I will add the same on the ticket as well. react-todo is an npm package. It is open-source and inspired by keep to-do list. We want to keep UI similar to keep. The drag icon should appear on the hover of the item. Like below image drag-and-drop-example

Also, we want to minimize peer dependency so that more people are able to use it. like you have added styled-components and react-beautiful-dnd. If possible do it without react-beautiful-dnd but styled-components is not needed. And add dependencies inside peer dependencies in packge.json if using any, So that whoever will use this package will know about it.

bhujoshi commented 2 years ago

Let me know in case any help is needed from me. Thanks

kamalkishor1991 commented 1 year ago

Closing this because of inactivity. @mkirvan00 please feel free to reopen if you plan to work on this.