uport-project / ethr-did

Create ethr DIDs
Apache License 2.0
259 stars 52 forks source link

add support for meta transactions #102

Closed strumswell closed 1 year ago

strumswell commented 1 year ago

fixes #98

With ethr-did-resolver getting its 6.2.0 update, I updated this dependency to reflect the underlying additions. This includes wrapping the create hash function and the corresponding signed methods doing the txs. Also added tests for it.

Let me know what you think!

strumswell commented 1 year ago

Made the requested changes! Are we good now?

mirceanis commented 1 year ago

Made the requested changes! Are we good now?

Almost :)

The gasLimit parameter that is deprecated in existing methods should not be copied to the new *Signed methods. Users should be using txOptions.gasLimit instead. Please add the @deprecated hints back for the existing methods and remove the gasLimit parameter from the new methods.

strumswell commented 1 year ago

Made the requested changes! Are we good now?

Almost :)

The gasLimit parameter that is deprecated in existing methods should not be copied to the new *Signed methods. Users should be using txOptions.gasLimit instead. Please add the @deprecated hints back for the existing methods and remove the gasLimit parameter from the new methods.

My bad, thanks for pointing this out. 😅

strumswell commented 1 year ago

Thank you so much for taking your time going through this! I had some time now and included all your suggestions but:

codecov[bot] commented 1 year ago

Codecov Report

Base: 87.96% // Head: 84.56% // Decreases project coverage by -3.39% :warning:

Coverage data is based on head (ad82bf5) compared to base (180c65c). Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ========================================== - Coverage 87.96% 84.56% -3.40% ========================================== Files 1 1 Lines 108 162 +54 Branches 41 59 +18 ========================================== + Hits 95 137 +42 - Misses 13 25 +12 ``` | [Impacted Files](https://codecov.io/gh/uport-project/ethr-did/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project) | Coverage Δ | | |---|---|---| | [src/index.ts](https://codecov.io/gh/uport-project/ethr-did/pull/102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-c3JjL2luZGV4LnRz) | `84.56% <77.77%> (-3.40%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

uport-automation-bot commented 1 year ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: