Closed strumswell closed 1 year ago
Made the requested changes! Are we good now?
Made the requested changes! Are we good now?
Almost :)
The gasLimit
parameter that is deprecated in existing methods should not be copied to the new *Signed
methods.
Users should be using txOptions.gasLimit
instead.
Please add the @deprecated
hints back for the existing methods and remove the gasLimit
parameter from the new methods.
Made the requested changes! Are we good now?
Almost :)
The
gasLimit
parameter that is deprecated in existing methods should not be copied to the new*Signed
methods. Users should be usingtxOptions.gasLimit
instead. Please add the@deprecated
hints back for the existing methods and remove thegasLimit
parameter from the new methods.
My bad, thanks for pointing this out. 😅
Thank you so much for taking your time going through this! I had some time now and included all your suggestions but:
MetaTransaction
type. I saw you already released a new version of the resolver that exports it. So bumped its version in the package and imported from there.txOptions
parameter in changeOwnerSigned
non-optional to be in line with the other signed methods.address
. You are not using this at all in other places so I just resolved them back to their underlying string
type. Then we also don't have to export this type anywhere.Base: 87.96% // Head: 84.56% // Decreases project coverage by -3.39%
:warning:
Coverage data is based on head (
ad82bf5
) compared to base (180c65c
). Patch coverage: 77.77% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
:tada: This PR is included in version 2.3.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
fixes #98
With ethr-did-resolver getting its 6.2.0 update, I updated this dependency to reflect the underlying additions. This includes wrapping the create hash function and the corresponding signed methods doing the txs. Also added tests for it.
Let me know what you think!