search

uport-project / ethr-did

Create ethr DIDs
Apache License 2.0
259 stars 52 forks source link

fix: add esm wrapper #105

Closed lleifermann closed 1 year ago

lleifermann commented 1 year ago

@mirceanis Adds the same esm module wrapping like in: https://github.com/decentralized-identity/ethr-did-resolver/commit/d2bbeafbd2d77308f12d73f952b0b9940431dd83

Also updated ethr-did-resolver to alpha to test the esm module from there as well already and it seems to work. We could add a alpha release channel here as well. Not sure though.

lleifermann commented 1 year ago

Nvm i think the jest setup needs some more work.

lleifermann commented 1 year ago

I closely followed what @mirceanis did here: https://github.com/decentralized-identity/ethr-did-resolver/pull/170 and this seems to fix the tests.

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.56% // Head: 84.56% // No change to project coverage :thumbsup:

Coverage data is based on head (8141a8e) compared to base (24b23ac). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #105 +/- ## ======================================= Coverage 84.56% 84.56% ======================================= Files 1 1 Lines 162 162 Branches 59 59 ======================================= Hits 137 137 Misses 25 25 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lleifermann commented 1 year ago

It seems everything works even without this PR so i will close this 😄