search

uport-project / ethr-did

Create ethr DIDs
Apache License 2.0
260 stars 54 forks source link

publicKey field is not conform to the W3C specs #21

Closed gjgd closed 3 years ago

gjgd commented 5 years ago

1) In the public key section of W3C specs it says that: The value property of a public key may be publicKeyPem, publicKeyJwk, publicKeyHex, publicKeyBase64 or similar, depending on the format and encoding of the public key. -> It not explicitly said, but it is implied that the format for the value property should bepublicKey<ENCODING> therefore the example in the README using ethereumAddress as the value property is not valid

2) In the W3C registry that summarizes the Linked Data key specifications currently known to the community, the identifier "Secp256k1VerificationKey2018" is not listed, but it is used in the README example.

gjgd commented 5 years ago

For reference, there is an open issue in the W3C specs to address the vagueness of the definition for item 1.

uport-automation-bot commented 3 years ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: