search

uport-project / ethr-did

Create ethr DIDs
Apache License 2.0
259 stars 53 forks source link

add method to revoke attributes closes #45 #46

Closed nikolockenvitz closed 4 years ago

nikolockenvitz commented 4 years ago

Created this PR corresponding to issue #45 to revoke attributes.

If further tests are wanted, I can of course add them.

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into develop will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    97.29%   97.40%   +0.10%     
===========================================
  Files            1        1              
  Lines           74       77       +3     
  Branches        25       25              
===========================================
+ Hits            72       75       +3     
  Misses           2        2
Impacted Files Coverage Δ
src/index.js 97.40% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5af1efb...f18d42c. Read the comment docs.

nikolockenvitz commented 4 years ago

any way I can help to merge this PR?

@mirceanis could you tell me whom I can contact / who is responsible for this?

mirceanis commented 4 years ago

any way I can help to merge this PR?

@mirceanis could you tell me whom I can contact / who is responsible for this?

@nikolockenvitz it's only a matter of resources. We didn't have any bandwidth to review this until now. Sorry it's taking this long.

nikolockenvitz commented 4 years ago

Thanks! 😃