search

uport-project / ethr-did

Create ethr DIDs
Apache License 2.0
263 stars 54 forks source link

3rd party funding #98

Closed jfromaniello closed 2 years ago

jfromaniello commented 2 years ago

The docs for ethr-did-registry mention this:

Since each Ethereum transaction has to be funded, there is a growing trend of on-chain transactions that are authenticated via an externally created signature and not by the actual transaction originator. This allows 3rd party funding services or receiver pays without any fundamental changes to the underlying Ethereum architecture.

I assume this is done by using the *Signed version of the methods like setAttributeSigned, but I couldn't find support for this in this library nor in the ethr-did-resolver.

Thanks!

mirceanis commented 2 years ago

The only samples of this in action are in the registry test suite: https://github.com/uport-project/ethr-did-registry/blob/bd6f1b78797baccb3b9ab1019fd61cf9890aa304/test/registry.test.ts#L587

Do you want to implement that kind of functionality here?

jfromaniello commented 2 years ago

Thank you @mirceanis , I also saw this test case.

First of all, I wanted to ask here because I wasn't sure "meta transactions" weren't implemented already, for example in ethers.

I am not sure if it should be here. I am just trying out did implementations and the documentation for did:ethr points to this library. I was able to add a public new public key and change the services in the did document, but I was wondering how for instance a wallet implementor/hub could take care of the fees and that's where I came across that section of the documentation.

If you think is a good idea to have it here I could give it a try to port the test case of the registry.

Thanks in advance

mirceanis commented 2 years ago

It makes sense to have the functionality expressed by this library. I don't have bandwidth to make this happen at the moment but would be happy to support you if you do. These kinds of contributions are always welcome!

mirceanis commented 2 years ago

This is being fixed in #102

uport-automation-bot commented 2 years ago

:tada: This issue has been resolved in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: