search

uport-project / kotlin-did-jwt

Create and verify uPort and DID compliant JWTs in Kotlin
https://developer.uport.me
Apache License 2.0
8 stars 6 forks source link

refactor: update dependency stack and isolate implementation details #22

Closed mirceanis closed 5 years ago

mirceanis commented 5 years ago

This PR updates kethereum to 0.76.1 and the kotlin-common libs to 0.3.x Because of downstream breaking changes, some dependency have to be explicitly declared now and some imports had to be adapted.

No functionality change was made, all tests were kept.

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into develop will decrease coverage by <.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #22      +/-   ##
=============================================
- Coverage      72.49%   72.48%   -0.01%     
  Complexity       178      178              
=============================================
  Files             24       24              
  Lines            858      865       +7     
  Branches         145      145              
=============================================
+ Hits             622      627       +5     
- Misses           158      160       +2     
  Partials          78       78
Impacted Files Coverage Δ Complexity Δ
...-did/src/main/java/me/uport/sdk/ethrdid/EthrDID.kt 42.37% <ø> (ø) 3 <0> (ø) :arrow_down:
.../main/java/me/uport/sdk/ethrdid/EthrDIDResolver.kt 81.21% <ø> (ø) 20 <0> (ø) :arrow_down:
...ava/me/uport/sdk/uportdid/UportIdentityDocument.kt 72.09% <ø> (ø) 4 <0> (ø) :arrow_down:
.../src/main/java/me/uport/sdk/ethrdid/RegistryMap.kt 100% <ø> (ø) 7 <0> (ø) :arrow_down:
jwt/src/main/java/me/uport/sdk/jwt/JWTTools.kt 81.09% <ø> (ø) 56 <0> (ø) :arrow_down:
...n/java/me/uport/sdk/jwt/test/EthrDIDTestHelpers.kt 94.73% <100%> (+1.87%) 1 <0> (ø) :arrow_down:
...ain/java/me/uport/sdk/uportdid/UportDIDResolver.kt 62.26% <25%> (-2.45%) 12 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82fd10b...bd1064d. Read the comment docs.

mirceanis commented 5 years ago

@friedger once this makes it into the next release you should be able to use it without any other dependency declarations: implementation "com.github.uport-project.kotlin-did-jwt:jwt:$did_jwt_version" You can test a prerelease now with did_jwt_version = "bd1064d4" No need to import kotlin-common anymore.

If other dependency issues arise, please let us know. I'm not sure how to spot them earlier so we appreciate any such feedback.

ugoamanoh commented 5 years ago

If you have removed the wip tag, would you like to update the description as well?

mirceanis commented 5 years ago

If you have removed the wip tag, would you like to update the description as well?

@ugoamanoh what do you mean?

ugoamanoh commented 5 years ago

If you have removed the wip tag, would you like to update the description as well?

@ugoamanoh what do you mean?

There was a statement in the description saying this PR was still marked as wip. I guess you have removed it now

mirceanis commented 5 years ago

Yes, that was removed yesterday. That's why I asked.