search

uport-project / kotlin-did-jwt

Create and verify uPort and DID compliant JWTs in Kotlin
https://developer.uport.me
Apache License 2.0
8 stars 6 forks source link

UniversalDID deprecation #34

Closed ugoamanoh closed 4 years ago

ugoamanoh commented 5 years ago

What's Here

Deprecated the existing UniversalDID singleton object in favor of new DIDResolver Builder approach for registering multiple resolvers. There is a new module uport-defaults added to enable configuring default resolvers on all known networks by supplying an infuraProjectId

This PR resolves the issue https://github.com/uport-project/kotlin-did-jwt/issues/32

In Progress

  1. Removing dependencies from jwt module
  2. Updating documentation
  3. Adding Tests

Testing

Run test suite using the command ./gradlew test cC --no-parallel

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into develop will increase coverage by 1.16%. The diff coverage is 84.61%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #34      +/-   ##
=============================================
+ Coverage      72.69%   73.86%   +1.16%     
- Complexity       181      186       +5     
=============================================
  Files             24       27       +3     
  Lines            868      922      +54     
  Branches         145      145              
=============================================
+ Hits             631      681      +50     
+ Misses           159      155       -4     
- Partials          78       86       +8
Impacted Files Coverage Δ Complexity Δ
...main/java/me/uport/sdk/universaldid/DIDResolver.kt 100% <ø> (ø) 0 <0> (?)
...ain/java/me/uport/sdk/universaldid/UniversalDID.kt 70% <ø> (-10%) 11 <0> (-4)
jwt/src/main/java/me/uport/sdk/jwt/JWTTools.kt 85.43% <ø> (+3.99%) 56 <0> (-2) :arrow_down:
...main/java/me/uport/sdk/uportdefaults/Extensions.kt 100% <100%> (ø) 0 <0> (?)
.../java/me/uport/sdk/universaldid/DIDResolverImpl.kt 66.66% <66.66%> (ø) 11 <11> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc507c2...e60035c. Read the comment docs.