search

uport-project / kotlin-did-jwt

Create and verify uPort and DID compliant JWTs in Kotlin
https://developer.uport.me
Apache License 2.0
8 stars 6 forks source link

Revocations #35

Closed ugoamanoh closed 4 years ago

ugoamanoh commented 4 years ago

What's Here

  1. To support revocations, we have added an interface StatusResolver in the credential-status module which can be implemented to enable checking the revocation status of a credential.

  2. This PR also contains an Ethr implementation of the StatusResolver called EthrStatusResolver in the ethr-status module which returns an EthrStatus, an extension of the CredentialStatus

  3. A UniversalStatusResolver which enables registration of several implementations of the StatusResolver and at runtime, delegates of which Resolver will be used to check the status of a credential.

  4. Tests to cover operations in EthrStatusResolver and UniversalStatusResolver. Use the command ./gradlew test cC --no-parallel to run the entire test suite

codecov[bot] commented 4 years ago

Codecov Report

Merging #35 into develop will increase coverage by 0.26%. The diff coverage is 78.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #35      +/-   ##
=============================================
+ Coverage      73.86%   74.13%   +0.26%     
- Complexity       186      199      +13     
=============================================
  Files             27       31       +4     
  Lines            922      978      +56     
  Branches         145      156      +11     
=============================================
+ Hits             681      725      +44     
- Misses           155      158       +3     
- Partials          86       95       +9
Impacted Files Coverage Δ Complexity Δ
.../java/me/uport/credential_status/StatusResolver.kt 100% <100%> (ø) 0 <0> (?)
...uport/credential_status/UniversalStatusResolver.kt 58.33% <58.33%> (ø) 4 <4> (?)
.../src/main/java/me/uport/credential_status/Utils.kt 66.66% <66.66%> (ø) 0 <0> (?)
...ava/me/uport/sdk/ethr_status/EthrStatusResolver.kt 86.48% <86.48%> (ø) 9 <9> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8837485...5da0f64. Read the comment docs.

ugoamanoh commented 4 years ago

@mirceanis Kindly review