search

uport-project / kotlin-did-jwt

Create and verify uPort and DID compliant JWTs in Kotlin
https://developer.uport.me
Apache License 2.0
8 stars 6 forks source link

Revocations support for ALL did types #42

Closed ugoamanoh closed 4 years ago

ugoamanoh commented 4 years ago

What's Here

This resolves the issue https://github.com/uport-project/kotlin-did-jwt/issues/38

This PR enables support for non-ethr-did addresses by creating a list of revokers from the public key entries in the did document.

Testing

Verified that the previous tests still pass and added new tests to validate the process of creating the list of revokers.

codecov[bot] commented 4 years ago

Codecov Report

Merging #42 into develop will decrease coverage by 0.56%. The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #42      +/-   ##
=============================================
- Coverage      74.13%   73.56%   -0.57%     
- Complexity       199      201       +2     
=============================================
  Files             31       32       +1     
  Lines            978      991      +13     
  Branches         156      156              
=============================================
+ Hits             725      729       +4     
- Misses           158      168      +10     
+ Partials          95       94       -1
Impacted Files Coverage Δ Complexity Δ
.../java/me/uport/credential_status/StatusResolver.kt 100% <ø> (ø) 0 <0> (ø) :arrow_down:
...ava/me/uport/sdk/ethr_status/RevocationContract.kt 16.66% <0%> (ø) 0 <0> (?)
...uport/credential_status/UniversalStatusResolver.kt 58.33% <0%> (ø) 4 <2> (ø) :arrow_down:
...ava/me/uport/sdk/ethr_status/EthrStatusResolver.kt 89.47% <92.3%> (+2.98%) 11 <1> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5da0f64...747a770. Read the comment docs.