Bring codecoverage to 100%

ajunge commented 5 years ago

Our codecov is not full 100% . According to this: https://codecov.io/gh/uport-project/lambda-caleuche/branch/develop we have 94.02%.

Mostly at: src/lib/s3Mgr.js src/api_handler.js

Smallest code posible. No calls to external services/APIs.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.25 ETH (39.21 USD @ $156.86/ETH) attached to it as part of the ConsenSys / uPort fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $43,951.11 more funded OSS Work available on the Gitcoin Issue Explorer

ajunge commented 5 years ago

@sounak98 let me know if you run into any issue

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

ajunge commented 5 years ago

@sounak98 how are you doing on this? Need any help?

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@sounak98 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

sounak98 commented 5 years ago

@ajunge sorry for the late response, I was actually busy with something else. I will start the work immediately and let you know ASAP!

ajunge commented 5 years ago

Ok @sounak98 let me know how it works

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 weeks, 6 days ago. Please review their action plans below:

1) agbilotia1998 has been approved to start work.

I will take a look at the code and the tests, the insights of uncovered statements, functions could help in making the required changes to tests and if needed to the code as well.

Learn more on the Gitcoin Issue Details page.

agbilotia1998 commented 5 years ago

@ajunge I am able to bring the code coverage up to 97.5%, the problem is that the tests in s3Mgr.test.js require the AWS S3 bucket credentials as the tests are not written for the cases when data operation is done correctly, only the errors are handled.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.25 ETH (21.1 USD @ $84.39/ETH) has been submitted by:

@agbilotia1998

@ajunge please take a look at the submitted work:

PR by @agbilotia1998

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$44,046.77 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

⚡️ A tip worth 0.02500 ETH (2.98 USD @ $119.37/ETH) has been granted to @agbilotia1998 for this issue from @. ⚡️

Nice work @agbilotia1998! Your tip has automatically been deposited in the ETH address we have on file.

$39954.25 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.25 ETH (29.84 USD @ $119.37/ETH) attached to this issue has been approved & issued to @agbilotia1998.

Additional Tips for this Bounty:

tipped 0.0250 ETH worth 2.98 USD to agbilotia1998.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$39,924.41 more funded OSS Work available on the Gitcoin Issue Explorer

ajunge commented 5 years ago

Thanx @agbilotia1998

uport-project / lambda-caleuche

Bring codecoverage to 100% #21