uport-project / uport-mobile

uPort mobile app
https://uport.me
GNU General Public License v3.0
76 stars 28 forks source link

Fixing issues with RN upgrade #161

Closed jasheal closed 5 years ago

jasheal commented 5 years ago

React native upgrade has a few minor issues.

This removes react-native-svg from the project and fixes issues with icon display and other minor minor issues

codecov[bot] commented 5 years ago

Codecov Report

Merging #161 into develop will decrease coverage by 0.92%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #161      +/-   ##
==========================================
- Coverage    58.02%   57.1%   -0.93%     
==========================================
  Files          254     235      -19     
  Lines         8278    8119     -159     
  Branches      1701    1665      -36     
==========================================
- Hits          4803    4636     -167     
- Misses        3088    3108      +20     
+ Partials       387     375      -12
Impacted Files Coverage Δ
lib/navigators/navigation.ts 0% <ø> (ø)
lib/screens/index.ts 0% <ø> (ø) :arrow_up:
lib/sagas/requests/index.js 65.84% <ø> (ø) :arrow_up:
lib/components/Request/index.js 0% <ø> (-62.97%) :arrow_down:
lib/components/Recovery/SeedRecoverySuccess.js 0% <ø> (ø) :arrow_up:
.../notifications/variants/InformationNotification.js 22.22% <ø> (+22.22%) :arrow_up:
lib/screens/onboarding/SecurityBlock.js 0% <ø> (ø) :arrow_up:
lib/screens/Notifications.js 29.09% <0%> (+29.09%) :arrow_up:
lib/components/Backup/SeedBackupSuccess.js 0% <0%> (ø) :arrow_up:
lib/components/Backup/DataBackupSuccess.js 0% <0%> (ø) :arrow_up:
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da4059f...b1c3f62. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #161 into develop will decrease coverage by 0.92%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #161      +/-   ##
==========================================
- Coverage    58.02%   57.1%   -0.93%     
==========================================
  Files          254     235      -19     
  Lines         8278    8119     -159     
  Branches      1701    1665      -36     
==========================================
- Hits          4803    4636     -167     
- Misses        3088    3108      +20     
+ Partials       387     375      -12
Impacted Files Coverage Δ
lib/navigators/navigation.ts 0% <ø> (ø)
lib/screens/index.ts 0% <ø> (ø) :arrow_up:
lib/sagas/requests/index.js 65.84% <ø> (ø) :arrow_up:
lib/components/Request/index.js 0% <ø> (-62.97%) :arrow_down:
lib/components/Recovery/SeedRecoverySuccess.js 0% <ø> (ø) :arrow_up:
.../notifications/variants/InformationNotification.js 22.22% <ø> (+22.22%) :arrow_up:
lib/screens/onboarding/SecurityBlock.js 0% <ø> (ø) :arrow_up:
lib/screens/Notifications.js 29.09% <0%> (+29.09%) :arrow_up:
lib/components/Backup/SeedBackupSuccess.js 0% <0%> (ø) :arrow_up:
lib/components/Backup/DataBackupSuccess.js 0% <0%> (ø) :arrow_up:
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da4059f...b1c3f62. Read the comment docs.