search

uport-project / uport-mobile

uPort mobile app
https://uport.me
GNU General Public License v3.0
76 stars 28 forks source link

Feature/167981388 onfido survey #178

Closed aldigjo closed 4 years ago

aldigjo commented 5 years ago

I created a new modal component for the survey since it has a different layout from the marketplace, but let me know if I should refactor marketplace instead of doing this.

I am also passing in a componentId to the modals so that they can be dismissed individually.

I think we need some more clarity on how both of the modals should flow together

codecov[bot] commented 5 years ago

Codecov Report

Merging #178 into develop will decrease coverage by 0.1%. The diff coverage is 23.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #178      +/-   ##
===========================================
- Coverage    58.25%   58.14%   -0.11%     
===========================================
  Files          233      233              
  Lines         6750     6764      +14     
  Branches       977      987      +10     
===========================================
+ Hits          3932     3933       +1     
- Misses        2442     2455      +13     
  Partials       376      376
Impacted Files Coverage Δ
lib/screens/Screens.ts 100% <ø> (ø) :arrow_up:
lib/screens/index.ts 0% <0%> (ø) :arrow_up:
lib/utilities/requestScreenManager.ts 26.92% <22.22%> (-6.42%) :arrow_down:
lib/utilities/fetchMarketplace.ts 16.66% <28.57%> (-11.91%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9638344...43d9a46. Read the comment docs.