search

uppsaladatavetare / foobar-api

The backend of the FooBar kiosk and inventory system.
MIT License
12 stars 6 forks source link

Cash register tracking #18

Closed ElinSwedin closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #18 into develop will increase coverage by 0.89%. The diff coverage is 97.19%.

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    86.79%   87.69%   +0.89%     
===========================================
  Files           71       73       +2     
  Lines         2204     2381     +177     
  Branches       114      125      +11     
===========================================
+ Hits          1913     2088     +175     
  Misses         275      275              
- Partials        16       18       +2
Impacted Files Coverage Δ
src/foobar/urls.py 60% <ø> (ø) :white_check_mark:
src/wallet/api.py 100% <100%> (ø) :white_check_mark:
src/foobar/wallet/api.py 100% <100%> (ø) :white_check_mark:
src/foobar/api.py 95.23% <100%> (+1.29%) :white_check_mark:
src/foobar/tests/test_api.py 100% <100%> (ø) :white_check_mark:
src/foobar/enums.py 100% <100%> (ø) :white_check_mark:
src/foobar/forms.py 100% <100%> (ø)
src/wallet/tests/test_api.py 100% <100%> (ø) :white_check_mark:
src/foobar/tests/test_views.py 100% <100%> (ø)
src/foobar/admin.py 60.74% <77.77%> (+1.21%) :white_check_mark:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ab2048...c844b5a. Read the comment docs.

flaeppe commented 7 years ago

WalletCorrection model could have a clean(self) function to check if amount == 0 otherwise it is not considered a correction?

kjagiello commented 7 years ago

The code is not compatible with Django 1.9 anymore, but I don't think it is an issue. I've got some changes in workings that are not compatible with Django 1.9 and as we are the only ones using this project at the moment, I propose we drop the 1.9 compatibility.

codecov-io commented 7 years ago

Codecov Report

Merging #18 into develop will increase coverage by 0.83%. The diff coverage is 95.85%.

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    86.88%   87.71%   +0.83%     
===========================================
  Files           71       73       +2     
  Lines         2218     2410     +192     
  Branches       115      126      +11     
===========================================
+ Hits          1927     2114     +187     
- Misses         275      278       +3     
- Partials        16       18       +2
Impacted Files Coverage Δ
src/foobar/urls.py 60% <ø> (ø) :white_check_mark:
src/foobar/forms.py 100% <100%> (ø)
src/wallet/api.py 100% <100%> (ø) :white_check_mark:
src/wallet/tests/test_api.py 100% <100%> (ø) :white_check_mark:
src/foobar/wallet/api.py 100% <100%> (ø) :white_check_mark:
src/foobar/tests/test_views.py 100% <100%> (ø)
src/foobar/api.py 95.4% <100%> (+1.46%) :white_check_mark:
src/foobar/tests/test_api.py 100% <100%> (ø) :white_check_mark:
src/foobar/enums.py 100% <100%> (ø) :white_check_mark:
src/foobar/admin.py 60.14% <66.66%> (+0.62%) :white_check_mark:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a663d96...9d01b87. Read the comment docs.

kjagiello commented 7 years ago

image It would be really nice to get some colors there. At a glance, you don't really see which entries are losses and which are "gains".

kjagiello commented 7 years ago

LGTM :+1: