search

uppsaladatavetare / foobar-api

The backend of the FooBar kiosk and inventory system.
MIT License
12 stars 6 forks source link

Out of stock forecasting #25

Closed kjagiello closed 7 years ago

kjagiello commented 7 years ago

Predict, based on recent sales, when a product will run out of stock.

codecov[bot] commented 7 years ago

Codecov Report

Merging #25 into develop will increase coverage by 0.16%. The diff coverage is 93.02%.

@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
+ Coverage    87.79%   87.96%   +0.16%     
===========================================
  Files           73       73              
  Lines         2417     2500      +83     
  Branches       125      134       +9     
===========================================
+ Hits          2122     2199      +77     
- Misses         277      282       +5     
- Partials        18       19       +1
Impacted Files Coverage Δ
src/shop/models.py 84.07% <100%> (+0.1%) :white_check_mark:
src/shop/querysets.py 91.66% <100%> (+1.66%) :white_check_mark:
src/shop/api.py 92.15% <100%> (+2.32%) :white_check_mark:
src/shop/tests/test_api.py 100% <100%> (ø) :white_check_mark:
src/shop/admin.py 58.17% <50%> (-0.72%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e7bd10...ea8fa2c. Read the comment docs.

kjagiello commented 7 years ago

Am I wrong or do we need to take weekends into account? FooBar is namely closed during weekends and currently the system can forecast that a product will run out of stock during a weekend, which will most likely not happen. What can we do about that? @flaeppe

kjagiello commented 7 years ago

I think we'll leave it as it is for now and see how it performs in action, then iterate on the idea, if necessary.