search

uppsaladatavetare / foobar-api

The backend of the FooBar kiosk and inventory system.
MIT License
12 stars 6 forks source link

Added url target for serving media files when running debug mode #38

Closed flaeppe closed 7 years ago

flaeppe commented 7 years ago

Not sure if url target is incorrectly placed(as the static() call should, per default, not do anything when running with the DEBUG=False flag).

However it is nice having urls for media files in place and not having to add anything to the code after running ./manage.py fetch_images locally.

codecov[bot] commented 7 years ago

Codecov Report

Merging #38 into develop will increase coverage by <.01%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    90.28%   90.28%   +<.01%     
===========================================
  Files           74       74              
  Lines         2800     2801       +1     
  Branches       150      150              
===========================================
+ Hits          2528     2529       +1     
- Misses         247      248       +1     
+ Partials        25       24       -1
Impacted Files Coverage Δ
src/foobar/urls.py 62.5% <100%> (+2.5%) :arrow_up:
src/shop/models.py 84.61% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb65ff...b9e393e. Read the comment docs.

flaeppe commented 7 years ago

@kjagiello PING.

Changes in place.