[Feature Request] No Duplicates and Force Diversity Options for Important Trainers

[MClarke93]

Is your idea a new setting, a change to an existing setting, or something else? Please describe clearly:

• An option to have the randomizer attempt to avoid giving important trainers (gym leaders, e4, champion, rivals, evil team boss) duplicate Pokemon, unless forced to by other settings (e.g. a type-themed trainer in a generation with a limited amount of that type available).
• An option to force traditionally "diverse" trainers (rivals, champions) to have a team of pokemon with no/few type overlaps.
• An option to ensure that, if type-themed, the 8 gyms and 4 elite 4 members, and champion, are distinct types.

What problem would this feature solve? Please describe:

• Although older Pokemon games frequently had duplicate Pokemon in fights (e.g. GSC Lance's 3 Dragonites), the modern convention is that major trainers shouldn't have duplicate Pokemon. Diversity is fun! As is having to play around different Pokemon. I'm always personally disappointed when I run a randomizer and see the champion with multiple of the same Pokemon, and have - in the past - deliberately checked the spoiler log and rerolled until the major encounters had no duplicates. It's particularly common when using type-theme and/or similar strength. It'd be nice to have the randomizer handle this for me, and would make it feel more "vanilla-like" too, by current standards.
• Similarly, although some champions are definitely type themed, there is also a recent trend in trying to make them diverse and well-rounded, as you would expect a top trainer to be. E.g. Cynthia. I think it'd be nice to have an option to make sure this happens for the champion at least, or possibly the rival.
• It's definitely convention that within the same game, type-themes don't repeat across the gyms and E4. I'm surprised this convention wasn't already implemented in ZX! Definitely feels more vanilla to make them all different types.

As with the other request, no expectations here. Just thanks for reading!

[foxoftheasterisk]

Oh, huh. I honestly didn't realize that the type themed gyms weren't already guaranteed to use different types. That part should be easy. The rest is a little harder, but I'm definitely interested in those features as well, so they're going on my list!

[foxoftheasterisk]

Ahhh, right. They did have logic to prevent duplicate types, except for some reason, gyms, elite 4, and champion were all treated as different groups. (Probably the reason is the Kanto gyms in the Johto games.)

Anyway, that's fixed in source now; elite four, champions, and the first 8 gyms now are guaranteed to be all different types. (Gyms after the first eight will then use the remaining types before picking duplicates, and will never choose duplicates of other gyms.)