search

uprm-inso4115-2023-2024-s2 / semester-project-automated-resume-builder

semester-project-automated-resume-builder created by GitHub Classroom
1 stars 0 forks source link

Identifying any underlying system problems #181

Closed GaddPetrivoki closed 5 months ago

GaddPetrivoki commented 7 months ago

Go over the code base and identify if there are any fundamental problems that have to be assessed urgently which could interfere with the ongoing development of the code

irsaris commented 7 months ago

@GaddPetrivoki Can you elaborate on this and are you sure this isn't being done already?

GaddPetrivoki commented 7 months ago

@GaddPetrivoki Can you elaborate on this and are you sure this isn't being done already?

@irsaris

I had originally checked across the issue lists and I didn't see anyone creating templates but checking past milestone it seems three templates were made under Issue #81. I couldn't find the branch nor how the templates were implemented but seems like it makes task #17 moot if there was already an implementation.

irsaris commented 7 months ago

Yeah, I see what you mean for task #81 maybe reach out to them and ask? Then you can edit this issue with what you think is needed and I'll review it again.

irsaris commented 7 months ago

what agreement was reached on this?

GaddPetrivoki commented 6 months ago

We went with his design as it's the one actively used.

irsaris commented 6 months ago

So was this done by both of you or is this issue a duplicate?

MrL9000 commented 6 months ago

@irsaris @Negroni1 As already partially stated, I identified that there was a large issue with the code basis, that being that the back-end could not see the resumes generated by the front end, and the back end was not storing said resumes, proof of this issue being that I handled it in merge https://github.com/uprm-inso4115-2023-2024-s2/semester-project-automated-resume-builder/commit/882e309498bdae90453bc1fad5bf333489d19a4f.