uprm-inso4117-2023-2024-s2 / semester-project-study-pet

semester-project-study-pet created by GitHub Classroom
1 stars 3 forks source link

[Doc Feedback] Fixes regarding function signature, behaviors and events #234

Closed irsaris closed 4 months ago

irsaris commented 5 months ago

"There is no reason to have a separate section domain events, actions, behaviors, and function signatures when you already have a section for the terminology. A "term" that your project needs can be of any kind: whether entity, action, event, or behavior. As a matter of fact, whether you consider something e.g. as an action or as a behavior might change depending on the level of abstraction you are currently interested in. Whether you talk about a "study session" (entity), "studying" (action), "studying - ... made up of a sequence of actions and events" (behavior), or "having just finished studying" (event), these all need to be clearly defined as terms and the place to do this is the terminology. Since your function signatures abstract some specific aspects of the actions, they too belong in the terminology together with the actions they help clarify.

To be domain behaviors the actions as well as the events that make these up will themselves be domain actions and domain events. They will therefore not involve any reference to the system-to-be. So, logging into the system, being a "user" etc. do not make sense here. The behaviors that you provide are behaviors, but they are not domain behaviors, but usage behaviors or interaction scenarios.

The reviewing of the study material with the flash card system is not visible in the function signature "RecordStudyProgress". You also need to check your other actions."

Follow up on the descriptions mentioned above by the professor to fix those details in the docuementation:

JorgeC08 commented 4 months ago

Updated the documentation to integrate domain events, actions, behaviors, and function signatures into the Terminology section as requested in the feedback. Removed system references from domain-specific elements and clarified function signatures to focus on domain interactions.

PinkSylvie commented 4 months ago

You removed most of the function signatures and events instead of editing them to add them into the terminology

PinkSylvie commented 4 months ago

@JorgeC08

JorgeC08 commented 4 months ago

Hello @PinkSylvie. I asked for your approval via discord but I’ll send it here.

I will modify sección 2.1.5 with this:

2.1.5 Domain Event, Actions, Behaviors, and Function Signatures To better our comprehension of user interactions and system responses of Study Pet, it is crucial to determine a clear distinction between events, actions, and behavior. This will aid in building a robust and intuitive user-friendly interface that facilitates the study and pet interaction processes. Behaviors: Terminology:

PinkSylvie commented 4 months ago

Did you? And also arent the actions and events missing?

JorgeC08 commented 4 months ago

Did you? And also arent the actions and events missing?

Got out of work and I'm currently working on it.

JorgeC08 commented 4 months ago

I added all the corresponding modifications. To my understanding, yes, it is completed.