Flashcards scrolling, removal restrictions and tests

williammartinez10 commented 2 months ago

This branch holds the work done for #296, #297, #298, #299, #317, and #318. It focuses on enabling scrolling on WebApp, adding restrictions for flashcard removal, and TDD test additions and fixes.

What was done:

Ensure that the user is also able to scroll through the flashcards overview screen on the WebApp, and polished flashcards overview screen layout to improve content and component visibility.
Added restrictions for flashcard management, in order to ensure that at least one study set is available for a pet to exist. Also, made sure that study set must also have at least one flashcard inside it.
Prevented removal of the last remaining flashcard in a study set, if there aren't more study sets available.
Fixed “remove all” functionality on WebApp and made sure it aligned with the new removal restrictions
Created new TDD tests for cases that didn’t have any (scrolling and remove all)
Updated creation and removal of flashcards TDD tests after the made changes

How to run tests?

Run npm run test-jest

What to look out for?
- New scroll test
- Updated flashcard removal test showcasing restrictions
  - Try removing first flashcard when it is the only one available and it is not possible
  - Added a second flashcard to the available study set, try removing it, and it is successful
- Updated test allowing creation and removal after layout changes
- New remove all test

PinkSylvie commented 2 months ago

I wasn't able to run the tests but it could be an issue on my side, happened when I was trying to run other tests as well. @irsaris does it happen on your side as well. If it runs on her then is on issue on my side and should be good to go.

irsaris commented 2 months ago

have these tests also been added to documentation? @williammartinez10

williammartinez10 commented 2 months ago

Yes

PinkSylvie commented 2 months ago

What section? You don't appear in the change log

williammartinez10 commented 2 months ago

Section 4.1.4

williammartinez10 commented 2 months ago

It should now appear in the change log

PinkSylvie commented 2 months ago

Can you add a screenshot with the tests passed into the section to show that the tests ran properly?

williammartinez10 commented 2 months ago

Done

PinkSylvie commented 2 months ago

The eat tests seem to have some errors as show in the picture

williammartinez10 commented 2 months ago

Yes, I believe that is part of another issue that may be assigned to someone else. I could create a separate file named flashcardsPage.test.js, and move all the tests that belong to the flashcards page over there, to get rid of that. However, those failed tests will still show up because that wasn't part of the issues i was working on.

PinkSylvie commented 2 months ago

Explain that then in the image description because fail tests with errors don't look good

williammartinez10 commented 2 months ago

Fixed it

PinkSylvie commented 2 months ago

Tried it out and it might be a small bug but I tried out the removal and while remove all didnt do anything when I pressed remove it removed all the question sets

PinkSylvie commented 2 months ago

Also please add the information regarding the tests you ran to the milestone 3 documentation

williammartinez10 commented 2 months ago

I believe the issue is now corrected. The information related to the tests has been added to the milestone 3 documentation under the TDD section.

williammartinez10 commented 2 months ago

Merge conflicts were solved, and documentation has been updated.

uprm-inso4117-2023-2024-s2 / semester-project-study-pet