search

uprm-inso4117-2023-2024-s2 / semester-project-study-pet

semester-project-study-pet created by GitHub Classroom
1 stars 3 forks source link

Automated property testing #323

Closed JConcepcion01 closed 2 months ago

JConcepcion01 commented 2 months ago

Added automated property testing. Closes #262. Further testing required

JConcepcion01 commented 2 months ago

Automated Testers now work, when verified, please merge.

PinkSylvie commented 2 months ago

How do you test run these tests?

JConcepcion01 commented 2 months ago

@PinkSylvie It's an automated test, like github metrics, so it runs on its one which was the point of the task. The only way to manually test it is with the "npx jest minigame.test.js" but that was basically from the task 255 that the other person did. So unless you push and pull, You cant really manually test it. That's why I had to do multiple push and pulls, to be able to test it and see what errors github threw at me when it finished analyzing it alongside checking for merge conflicts.

PinkSylvie commented 2 months ago

Did you add to the documentation about this?

PinkSylvie commented 2 months ago

Also please fix the conflicts

JConcepcion01 commented 2 months ago

@PinkSylvie I'll solve the merge conflicts in a bit. About the documentation, didnt know about that. I see A whole section of a bunch of subs-sections that all go about testing. Any specific place you wish for me to put it or do I choose any? Cuz Im honestly not fully sure

PinkSylvie commented 2 months ago

I think a new section under section 4 will be needed. Make sure to add the section in the table of contents as well

JConcepcion01 commented 2 months ago

@PinkSylvie I got a question, someone just brought up to me that task #264 exists. Should I still add it or is it up to the person assigned to that task? I dont mind adding it, just want to make sure.

PinkSylvie commented 2 months ago

Keep it in bay just in case so since @bally7301 should look onto what you did to be able to complete it. I think at the very least you should add an explanation of the automation while @bally7301 summarizes the results and conclusions of the feedback. Also please fix the conflicts, after this is done it should be fine to merge

JConcepcion01 commented 2 months ago

Solved the merge conflicts. All good to merge with main now