search

uprtcl / js-uprtcl-server

Uprtcl JS web-server service provider
http://uprtcl.io
Other
4 stars 5 forks source link

Add search "above" a perspective. #54

Closed pepoospina closed 3 years ago

pepoospina commented 3 years ago

Equivalent to under, but filter the reverse ecosystem of a perspective.

sotous commented 3 years ago

Latest updates about the feature here:

https://github.com/uprtcl/js-uprtcl-dev/tree/above-search-option

pepoospina commented 3 years ago

I was reviewing the implementation and it seems the levels property of the SearchOptionsEcoJoin object are being applied to all elements in the under/above set, and not to each element. And that the levels property of each JoinElement is not used.

Should we remove the levels property in the SearchOptionsEcoJoin and use only the levels of each element in the JoinElement[] array?

pepoospina commented 3 years ago

Ok, I've seen now that those levels was there to be applied to the forks property. Maybe they can be added inside the forks option to be more explicit.