upscayl / custom-models

A repository for extra custom models for Upscayl.
254 stars 27 forks source link

Cannot add custom models folder (Windows 10) #4

Closed Wlassko closed 1 year ago

Wlassko commented 1 year ago

Hi,

i tryed to add custom models folder by instructions here (download zip, extract, select models folder) , but if I select folder "models" then Upscayl report error:

ups251_err Please make sure that folder name is 'models' and nothing else.

log: 🐞 BACKEND REPORTED: ❌ Invalid Custom Models Folder Detected: Not a 'models' folder

I dont know what I doing wrong. Upscayl 2.5.1, OS Windows 10 x64 19045.3031, I tryed run Upscayl as admin, extract folder "models" to root C: drive (C:\models) , but nothing help, still the same error. Thanks for help.

NayamAmarshe commented 1 year ago

Try putting the folder somewhere else. Maybe in Documents.

Wlassko commented 1 year ago

Thanks for tip - results:

C:\Users\UserName\Documents\models - Error C:\Users\Public\Documents\models - Error C:\Documents\models - Error C:\models - Error ... any other drive - root or next folders - Error

And if I copy models to Upscayl folder (Program Files) models then nothing - Upscayl show only basic models, ignore custom added. I dont know what to do. But anyway thanks. Maybe others in newer Windows 11 doesnt have any problems with custom models, I dont know. Thanks for trying to help me, and sorry for wasting your time :)

NayamAmarshe commented 1 year ago

Thanks for tip - results:

C:\Users\UserName\Documents\models - Error C:\Users\Public\Documents\models - Error C:\Documents\models - Error C:\models - Error ... any other drive - root or next folders - Error

And if I copy models to Upscayl folder (Program Files) models then nothing - Upscayl show only basic models, ignore custom added. I dont know what to do. But anyway thanks. Maybe others in newer Windows 11 doesnt have any problems with custom models, I dont know. Thanks for trying to help me, and sorry for wasting your time :)

Please don't apologize, if I missed an edge case, I am to be blamed. It's very strange that it gives you the error.

Could you please try to select a models folder and after the error appears, copy the log (using the copy button) from the settings tab and paste it here in code blocks? image

Thank you!

Wlassko commented 1 year ago

Error log from Upscayl:

_Getting saveImageAs from localStorage png Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"} Setting gpuId to empty string Setting model to GET_MODELS_LIST:
Resetting image paths Setting model to ultramix_balanced Getting saveImageAs from localStorage png Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramixbalanced"} Setting gpuId to empty string Getting rememberOutputFolder from localStorage false BACKEND REPORTED: Invalid Custom Models Folder Detected: Not a 'models' folder

That was for case when models was in C:\models , thanks :) (Upscayl runned with admin privileges)

In code:

⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🎯 GET_MODELS_LIST:  
🔄 Resetting image paths
🔀 Setting model to ultramix_balanced
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false
🐞 BACKEND REPORTED:  ❌ Invalid Custom Models Folder Detected: Not a 'models' folder
Wlassko commented 1 year ago

Solved - models sucesfully imported in Upscayl 2.5.5. Thanks.