upscayl / upscayl

🆙 Upscayl - #1 Free and Open Source AI Image Upscaler for Linux, MacOS and Windows.
https://upscayl.org
GNU Affero General Public License v3.0
31.42k stars 1.45k forks source link

File limitation when batch upscaling #667

Closed mindthemix closed 8 months ago

mindthemix commented 10 months ago

Checklist

Describe the Bug

I tried to upscale 2K files but the upscaling stopped at file 178.

Is there a file limit?

Thanks.

To Reproduce

Uploading more than 178 files and run batch upscaling

Version (or commit hash)

2.9.8

Did you download Upscayl from the Mac App Store?

Select your Operating System

MacOS

OS Version

14.2.1

GPU Name

MacBook Pro M3

Expected Behavior

No response

Screenshots

No response

Paste the logs

🎯 GET_MODELS_LIST:  /Users/refueladmin/Library/CloudStorage/OneDrive-refuelagency.com/Resources/custom-models-main/models
🧠 Recalling Output Folder:  /Users/refueladmin/Creative Cloud Files/Scaling/Batch #2 for review
🐞 BACKEND REPORTED:  📁 Updating Custom Models Folder Path:  /Users/refueladmin/Library/CloudStorage/OneDrive-refuelagency.com/Resources/custom-models-main/models
🐞 BACKEND REPORTED:  📁 Custom Models Folder Path:  /Users/refueladmin/Library/CloudStorage/OneDrive-refuelagency.com/Resources/custom-models-main/models
⚙️ Getting saveImageAs from localStorage:  jpg
⚙️ Getting model from localStorage:  {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔀 Setting model to realesrgan-x4plus-anime
🐞 BACKEND REPORTED:  📁 Updating Output Folder Path:  /Users/refueladmin/Creative Cloud Files/Scaling/Batch #2 for review
🐞 BACKEND REPORTED:  💾 Updating Save Output Folder:  true
⚙️ Getting saveImageAs from localStorage:  jpg
⚙️ Getting model from localStorage:  {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage:  true
⚙️ Getting saveImageAs from localStorage:  jpg
⚙️ Getting model from localStorage:  {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔀 Setting model to realesrgan-x4plus-anime
⚙️ Getting saveImageAs from localStorage:  jpg
⚙️ Getting model from localStorage:  {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage:  true
aaronliu0130 commented 10 months ago

Could you give us the logs for when you try to Upscayl?

mindthemix commented 10 months ago

Hi there,

Thanks for the prompt reply.

Attached is the log.

Thx/F

On Jan 25, 2024, at 11:31 AM, Aaron Liu @.***> wrote:

Could you give us the logs for when you try to Upscayl?

— Reply to this email directly, view it on GitHub https://github.com/upscayl/upscayl/issues/667#issuecomment-1910562470, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE7LXNTP6TCCPBUMZCHJSSDYQKCEXAVCNFSM6AAAAABCJNQ7GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGU3DENBXGA. You are receiving this because you authored the thread.

aaronliu0130 commented 10 months ago

Email attachments do not send to GitHub. Try attaching it on GitHub’s web interface.

mindthemix commented 10 months ago

I will. Thanks for letting me know Sent from my iPhoneOn Jan 25, 2024, at 1:10 PM, Aaron Liu @.***> wrote: Email attachments do not send to GitHub. Try attaching it on GitHub’s web interface.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

mindthemix commented 10 months ago

Please find attached the logs.

log.rtf.zip

aaronliu0130 commented 10 months ago

The logs say 2900+ files were successfully upscaled and nothing ever stopped. Are you sure it only output 178? The output is located in /Users/refueladmin/Desktop/Batch #2 for review/upscayl_realesrgan-x4plus-anime_x4.

mindthemix commented 10 months ago

Please check the video. The batch is 2,420 files, and only 128 were scaled.

https://github.com/upscayl/upscayl/assets/155106230/e22d1a1a-0385-48f1-983c-9ec6ca21dbdc

Log batch scaling.zip

aaronliu0130 commented 10 months ago

Okay, this is very weird. @NayamAmarshe Any ideas?

mindthemix commented 10 months ago

All files are jpg and have no special characters.

mindthemix commented 10 months ago

After a quick experiment, it worked.

Locally upscaling files always limits you to 128 or 178 files. My setup is a Macbook Pro M3 Max, 16‑core CPU, 40‑core GPU and 128GB RAM. As soon as I moved all 5K files to an external HD connected to my iMac, it scaled all the files from the M3 settings folders.

Perhaps the M3 specs are overkill when running files locally?

NayamAmarshe commented 10 months ago

After a quick experiment, it worked.

Locally upscaling files always limits you to 128 or 178 files. My setup is a Macbook Pro M3 Max, 16‑core CPU, 40‑core GPU and 128GB RAM. As soon as I moved all 5K files to an external HD connected to my iMac, it scaled all the files from the M3 settings folders.

Perhaps the M3 specs are overkill when running files locally?

It's possible. I'll update Vulkan in the next release to see if that fixes it.

njardim commented 9 months ago

I had similar problems while upscaling around 972 files to a specific width, i.e., 2160px. The batch ran for over 6 hours, and when it finally finished, it left all files upscaled to 4x the size of the original files and not with the width I had specified. 

With a number under 180 files, the batch runs fine, but larger batches won't complete correctly. I've tested this several times.

Also, I've noticed that the batch upscales all files to 4x the size of the original file while running, and that it's only at the end of the batch process that all the files are resized to the specific size set by the user. So, my question is, can't the batch complete the upscale process for each individual file and only then move on to the next one?

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still happening, please reply to indicate so.

Omg12270 commented 3 weeks ago

is there any like size limit because iam only getting 10 images upscaled