search

upsidedownlabs / BioAmp-EXG-Pill

BioAmp EXG Pill is a small and elegant Analog Front End (AFE) board for BioPotential signal acquisition.
https://www.crowdsupply.com/upside-down-labs/bioamp-exg-pill
Other
277 stars 65 forks source link

Images in docs have incorrect URL's #23

Closed chrisb2 closed 2 years ago

chrisb2 commented 2 years ago

For example in electromyography.md the first image has a URL of https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/%20images/EMG/bioamp-exg-pill-emg-wave.jpg which has a space (%20) in front of the images directory, without this space the URL would be correct.

Chris

lorforlinux commented 2 years ago

Hey @chrisb2, The issue has been resolved. Can you please check and confirm?

chrisb2 commented 2 years ago

Sorry looking through the Readmes I can see remaining broken links and the embedded videos are just showing as iframes in the rendered markdown.

lorforlinux commented 2 years ago

Ohh okay, sorry for the inconvenience caused. Can you please point me to that broken link?

chrisb2 commented 2 years ago

Broken video iframes in: https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electromyography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrocardiography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electroencephalography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrooculography.md

Broken image links in: https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrocardiography.md

KhanFiza896 commented 2 years ago

Broken video iframes in: https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electromyography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrocardiography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electroencephalography.md https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrooculography.md

Broken image links in: https://github.com/upsidedownlabs/BioAmp-EXG-Pill/blob/main/docs/electrocardiography.md

Hey @chrisb2, video iframe links are not broken, it's just a code in \docs. You can check embedded website here https://upsidedownlabs.github.io/BioAmp-EXG-Pill/#/.