search

upsidr / merge-gatekeeper

Get better merge control
MIT License
92 stars 15 forks source link

Add new feature for check-other-job-status #1

Closed hlts2 closed 3 years ago

hlts2 commented 3 years ago

WHY

In order for PR to be blocked for merge, the branch restriction setup needs to pinpoint which CI job to be successful. We need a parent job which runs at the end, and checks other CI job status.

WHAT

I create a custom GitHub actions job that checks other CI job status. When we use it, give this job the required check flag. Then, this job can monitor other job statuses and merge them if all jobs are successful.

this is example yaml of this job. https://github.com/upsidr/merge-gatekeeper/blob/feature/example/merge-gatekeeper.yml

hlts2 commented 3 years ago

@rytswd thank you for your feedback. I have updated PR description and added example workflow. https://github.com/upsidr/check-other-job-status/pull/1#issue-702142981

btw, There's a couple of things I need to fix, so I'll keep working on those! Thank you!

hlts2 commented 3 years ago

@rytswd thank you for reviewing :bow: I will merge this pr to the main branch!!