Closed hlts2 closed 2 years ago
Also, you seem to have not included any fix for the verbose error message when the job fails?
@rytswd
Thanks, LGTM - just a quick one though, this won't fix the issue we saw internally with some job being picked up incorrectly for the total number of jobs?
I think the implementation of this link has solved that problem.
Also, you seem to have not included any fix for the verbose error message when the job fails?
if the job fails, we can get failed job name.ref:
https://github.com/upsidr/merge-gatekeeper/blob/bugfix/fix-timing-to-finish-job/internal/validators/status/status.go#L20-L21. but I could not delete CLI usage information. 🙏
So I will try this with another PR.
This pr contains the following implementations.
skipped
, exclude this job from validation logic.