upsidr / merge-gatekeeper

Get better merge control
MIT License
90 stars 15 forks source link

Bugfix of job handling #18

Closed hlts2 closed 2 years ago

hlts2 commented 2 years ago

This pr contains the following implementations.

rytswd commented 2 years ago

Also, you seem to have not included any fix for the verbose error message when the job fails?

hlts2 commented 2 years ago

@rytswd

Thanks, LGTM - just a quick one though, this won't fix the issue we saw internally with some job being picked up incorrectly for the total number of jobs?

I think the implementation of this link has solved that problem.

Also, you seem to have not included any fix for the verbose error message when the job fails?

if the job fails, we can get failed job name.ref: https://github.com/upsidr/merge-gatekeeper/blob/bugfix/fix-timing-to-finish-job/internal/validators/status/status.go#L20-L21. but I could not delete CLI usage information. 🙏 So I will try this with another PR.