search

upsidr / merge-gatekeeper

Get better merge control
MIT License
85 stars 14 forks source link

fix typo on ignored arg #31

Closed tekiflo closed 2 years ago

tekiflo commented 2 years ago

Following https://github.com/upsidr/merge-gatekeeper/pull/30

My bad, the new cli arg was not working. correctly use ignored on cli args too.

tekiflo commented 2 years ago

By the way, I'm not sure what happens if the ignored argument is used with an empty string. Is it correctly ignored?

j343my commented 2 years ago

GO GO :D

rbtmathieu commented 2 years ago

By the way, I'm not sure what happens if the ignored argument is used with an empty string. Is it correctly ignored?

It breaks whether there is ignored arguments given or not

rytswd commented 2 years ago

I think the empty string will be correctly ignored, so it should be fine 👍

tekiflo commented 2 years ago

Thanks for the review! Just tested the action with and without using ignored setting, everything worked as expected 👍