search

upsidr / merge-gatekeeper

Get better merge control
MIT License
84 stars 13 forks source link

Add support for retry merge-gatekeeper failure #41

Open aradwyr opened 1 year ago

aradwyr commented 1 year ago

It'd be helpful to be able to retry in the event of a merge-gatekeeper failure

rytswd commented 1 year ago

Hi @aradwyr, thanks for filing an issue! ☺️

Could you please elaborate what you mean by "merge-gatekeeper failure"? Merge Gatekeeper does simple polling for the predefined timeout duration (default set to 600 sec), and if it exceeds that it goes to the failure state. If some jobs took longer than 10 min, you can simply rerun Merge Gatekeeper job - do you mean to get some other control for such a rerun?

muratkeremozcan commented 2 months ago

Hi @aradwyr, thanks for filing an issue! ☺️

Could you please elaborate what you mean by "merge-gatekeeper failure"? Merge Gatekeeper does simple polling for the predefined timeout duration (default set to 600 sec), and if it exceeds that it goes to the failure state. If some jobs took longer than 10 min, you can simply rerun Merge Gatekeeper job - do you mean to get some other control for such a rerun?

If we retry a failing job (terrible practice, but zealously worshipped by engineers) , that job passes, and we rerun merge gatekeeper, merge gatekeeper will still pick on the failing job although now it passes.

The solution becomes git commit --allow-empty -n -m "rerun" && git push .

aradwyr commented 1 month ago

@markrmullan maybe you can forward this to the right person since I've left