search

upsidr / merge-gatekeeper

Get better merge control
MIT License
85 stars 14 forks source link

Multiple jobs with the same name are treated as one job. #60

Open krukowskid opened 1 year ago

krukowskid commented 1 year ago

Hi there, I am using reusable workflows and most of the workflows trigger the same set of jobs like

  - build-and-test / build
  - build-and-test / terraform-plan (prd, xwrd)
  - build-and-test / terraform-plan (dev, xwrd)
  - check-prstats / stats

It turns out that merge-gatekeeper v1.2.0 treats jobs with a common name as one job, and if one workflow succeeds while others are still running, it returns success. If any workflow fail before the first success then it returns failure

image

rytswd commented 1 year ago

Hi @krukowskid - thanks for raising the issue! ☺️

We haven't been using reusable workflows internally, but this is certainly something we need to fix. We will check more into this and get a patch release out as soon as we can 🙏

mmellison commented 1 year ago

We recently ran into this issue as well since we decided to use reusable workflows and composite actions.

But otherwise thank you for this awesome project. We recently migrated some Monorepos from GitLab and we were shocked to find out GitHub doesn't have this functionality built in.