Refactoring

[upsiflu]

Reduce Cognitive complexity

elm-review --template jfmengels/elm-review-cognitive-complexity/example --rules CognitiveComplexity yields the following hot sites:

• [ ] Accordion.view → 18
  • [ ] Collapse Accordion to its own History
  • [ ] On view, recalculate the regions
  • [ ] The regions can very well be Ui.Layout.Aspects
  • [ ] Remove the veryFarAway and check if it really deteriorates the performance
    • Replace all images with load-on-intersect images for much smaller load
• [ ] Segment.view → 30
  • Offload some viewing to Article.view
• [ ] Occurrence.occasionToString -> 22
  • Make little helper functions for the formats and then simplify the if expression
• [ ] Zipper.Tree.go -> 28
  • remove go functionality or make it more functional and less overloaded

Reduce Intermediate State Caching

• [ ] Remove Accordion and Article in-memory types and replace them with their respective History type
  • [ ] view must first interpret the history (in a List.foldl (|>))

Factor out drawing functions

• [ ] Merge Layout and Control?

Integrate restrictive UI 1.0 once finished

• [x] constant href for the main menu
• [x] bounce for each segment header
• [x] manual hrefs in the articles need to be interpreted such that flags and assignments are preserved: UrlClicked -> interpret as relative!