search

upsight / dinghy

Dinghy implements leader election using the raft protocol
MIT License
15 stars 4 forks source link

split brain issue? #8

Open dbainbri-ciena opened 10 months ago

dbainbri-ciena commented 10 months ago

I am experimenting with dinghy using 3 nodes each in their own container. I noticed that when I shutdown 2 of the nodes the remaining node becomes the leader. This would mean, i think, that if there was a network issue such that the node "a" was cut off from nodes "b" and "c", then node "a" would become a leader and "b" and "c" would elect a leader as well.

This was different from my assumption in that I expected that in the case where a consensus could not be reached no leader would be elected. Is my assumption just incorrect for this implementation?

dbainbri-ciena commented 10 months ago

I think the condition for TooFew needs to be modified to votes < int(len(d.Nodes)/2)+1. Still testing this. I am also noticing that the when the initial leader is lost it takes a significant time to re-elect.