search

upskill2 / shape-service

0 stars 0 forks source link

Code review #1

Open lutsenko87 opened 4 months ago

lutsenko87 commented 4 months ago

https://github.com/upskill2/shape-service/blob/82aced8563e2cf1b5d7ac2bd5bc96aaf2c1084aa/src/main/java/com/shape/service/controller/ShapeController.java#L21 it's unnecessary to use query params for POST HTTP method

https://github.com/upskill2/shape-service/blob/82aced8563e2cf1b5d7ac2bd5bc96aaf2c1084aa/src/main/java/com/shape/service/controller/ShapeController.java#L21 Why don't you use Enum instead of String (it will support inner validation)

https://github.com/upskill2/shape-service/blob/82aced8563e2cf1b5d7ac2bd5bc96aaf2c1084aa/src/main/java/com/shape/service/component/AreaCalculatorServiceFactory.java#L21 You don't understand the DI of Spring

Looks like candidate have not enough knowledge of Spring

upskill2 commented 4 months ago

Hi, thanks for the review! It would be very interesting to discuss comment about factory class on interview. But as Kateryna informed, there are more stronger solutions and it is decided not to move forward with me.