[RateLimit] Nothing displayed on `Rate Limit Analytics` panel because the `identifier` is not a valid ip?

[dreamer2q]

My Code as follows:

1. create a common function for reuse

import { Ratelimit } from '@upstash/ratelimit';
import redis from '../redis';
import { getRealIp } from './ip';

/**
 * @param {string} key
 * @param {number} token
 * @param {string} duration
 * @returns
 */
export function createRateLimit(key, tokens, duration) {
  const limiter = new Ratelimit({
    redis,
    limiter: Ratelimit.fixedWindow(tokens, duration),
  });

  return {
    check: async (req, res) => {
      const reqIp = getRealIp(req);
      const reqIdentifier = `${reqIp}:${key}`; // please note here, its not a valid ip, it got a suffix~
      const { success, limit, remaining, reset } = await limiter.limit(
        reqIdentifier,
        req
      );
      res.setHeader('X-RateLimit-Limit', limit);
      res.setHeader('X-RateLimit-Remaining', remaining);
      res.setHeader('X-RateLimit-Reset', reset);
      return success;
    },
  };
}

2. use it in any api route I want to setup ratelimit

const limit = createRateLimit('search', 50, '1h'); // please note the key

/**

• @param {import('next').GetServerSidePropsContext} param0
• @returns */ export async function getServerSideProps({ req, res, query }) { const passed = await limit.check(req, res); if (!passed) { return { redirect: { destination: '/error?msg=' + encodeURIComponent('RateLimit Error or anything you like here~'), }, }; } ...... }

after that, deployed, and worked, but nothing in Rate Limit Analytics panel.

I have checked the rawData, its working ~

It looks that the Panel not recoginized with what I set as an identifier~ Bad news.

[dreamer2q]

Sample Picture of Data View here, please take note of the key !!!

[chronark]

hey, you need to opt into analytics:

new Ratelimit({
    redis,
    limiter: Ratelimit.fixedWindow(tokens, duration),
    analytics: true // <-  
  });

[dreamer2q]

hey, you need to opt into analytics:

new Ratelimit({
    redis,
    limiter: Ratelimit.fixedWindow(tokens, duration),
    analytics: true // <-  
  });

The analytics default is true, am I wrong?

[chronark]

It was true on accident, we have set it to false in the latest version, since we don't want to add any cost to our users by default what version are you on?

[dreamer2q]

I will set analytics: true and redeploy to see if working.

It was true on accident, we have set it to false in the latest version, since we don't want to add any cost to our users by default what version are you on?

package.json says "@upstash/ratelimit": "^0.4.2" as well as yarn.lock

[dreamer2q]

Thanks for your attention. Its working now~ closed.

Docs should follow the latest code as it suggests or whatever

[dreamer2q]

It was true on accident, we have set it to false in the latest version, since we don't want to add any cost to our users by default what version are you on?

OMG I need to know how much cost it will increase? or I would consider altertives ...

[dreamer2q]

The Github seems to experience an accident just now :(

[chronark]

it adds 1 command per limit invocation

[dreamer2q]

it adds 1 command per limit invocation

So the usage is doubled if analytics enabled?

[chronark]

that depends on the algorithm used. you can check here where all the algorithms are implemented