search

upstash / pulumi-upstash

Apache License 2.0
8 stars 2 forks source link

Mark `readOnlyRestToken` as secret #14

Open mattfysh opened 10 months ago

mattfysh commented 10 months ago

Currently only restToken and password are marked as secret outputs, but I believe the read-only REST token should also be included. Cheers!

praneetloke commented 10 months ago

@mattfysh Pulumi supports specifying additional properties as secret outputs through the resource option additionalSecretOutputs. Would that work for you as a workaround?

mattfysh commented 10 months ago

@praneetloke this is great, I'll use it instead. It would be nice to have it in the SDK so that it's not something you can forget to add, but this'll do for now. Cheers!

praneetloke commented 10 months ago

It would be nice to have it in the SDK so that it's not something you can forget to add

@mattfysh agreed. I think you should reopen this issue to track that perhaps?

mattfysh commented 6 months ago

This would be fixed by https://github.com/upstash/terraform-provider-upstash/issues/37

mattfysh commented 4 months ago

Hi @praneetloke - the upstream terraform provider has merged the fix: https://github.com/upstash/terraform-provider-upstash/pull/39

Is it possible to pull through the updated via source, or do we need to wait for a versioned release to hit the terraform registry? thanks!

praneetloke commented 4 months ago

Hi @mattfysh, it's controlled by the version of the upstream provider that this provider depends on in go.mod. Someone from Upstash would need to update this provider to either point to an updated release of the TF provider (for which Upstash would have to do a new release) or update this to point to a specific commit in the TF provider repo since Go modules support pseudo-versions by referencing a commit hash.

Either way, this provider would need to be updated so the updated version is available in all the relevant language registries (npm, PyPi etc.) The alternative of forking this repo leads to more work and undesirable in my opinion unless it's warranted due to some breaking issue (or if this provider is abandoned.)

cc @burak-upstash