Add disableHistory option (Fixes #44)

upstash / rag-chat

Batteries included SDK for RAG development.

https://upstash.com/docs/vector/sdks/rag-chat/gettingstarted

MIT License

170 stars 46 forks source link

Add disableHistory option (Fixes #44) #47

Closed eraykeskinmac closed 3 months ago

eraykeskinmac commented 3 months ago

This PR implements the disableHistory option for the RAGChat class as requested in issue #44. Here's what this PR includes:

Added disableHistory option to ChatOptions
Updated RAGChat class to handle the new option
Implemented logic to skip history recording when disableHistory is set to true
Added tests to verify the new functionality

This feature allows users to disable history recording for specific chat interactions, providing more flexibility in how chat history is managed.

Testing:

Added unit tests for the new functionality
Manually tested the feature to ensure it works as expected

Note: Some tests may fail due to missing environment variables. I've used the QStash token as suggested, but please let me know if any adjustments are needed.

ogzhanolguncu commented 3 months ago

@enesakar is this what you imaged? Let me know.

enesakar commented 3 months ago

cok tesekkurler @eraykeskinmac

enesakar commented 3 months ago

devamini bekleriz @eraykeskinmac

eraykeskinmac commented 3 months ago

@enesakar Çok teşekkürler abi! Devamı için çalışıyorum, projeyi inceledikçe daha fazlasını yapmak istiyorum.

ogzhanolguncu commented 3 months ago

@eraykeskinmac This is good, but I think we should also consider whether we want to fetch history from the store. @enesakar what do you think?

enesakar commented 3 months ago

when historyDisabled, the SDK should not call redis (to fetch history)

ogzhanolguncu commented 3 months ago

@eraykeskinmac Addition to what we have right now, can you disable history fetch when disableHistory is active?

eraykeskinmac commented 3 months ago

@ogzhanolguncu Sure i will add that feature to disable history fetch when disableHistory is active

ogzhanolguncu commented 3 months ago

@eraykeskinmac There were lots of conflicts I moved all your commits to https://github.com/upstash/rag-chat/pull/57 here. Your contributions are still there so nothing to worry about.