search

upstash / ratelimit-js

Rate limiting library for serverless runtimes
https://ratelimit-with-upstash.vercel.app/
MIT License
1.72k stars 34 forks source link

ioredis compatibility #115

Open bkniffler opened 3 months ago

bkniffler commented 3 months ago

Any chance we could get this ioredis compatible? Would like to use upstash via ioredis to remove http overhead, and ioredis is one of the recommended clients for upstash, but its not compatible with ratelimit-js.

ogzhanolguncu commented 3 months ago

Totally doable, but our main focus on serverless environments. Maybe we can let people use ioredis and/or redis for serverful environments. I'll discuss this with the team.

Edit: For now you can do the following -> https://github.com/upstash/ratelimit-js/issues/60

sourabpramanik commented 3 months ago

@ogzhanolguncu If the team is moving forward with this integration, I would like to work on it.

bkniffler commented 3 months ago

@ogzhanolguncu the linked solution does not work, up stash rate limit depends on more functions by now. hset, evalsha, scriptLoad, smismember, multi

Bildschirmfoto 2024-07-26 um 11 16 44

using ioredis for these methods seems to not work either out of the box, think the adapter needs more effort to be made working. would love this to be part of ratelimit-js, then at least its clear when compatibility breaks.

bkniffler commented 2 months ago

Any chance this is going to land sometime?

ogzhanolguncu commented 2 months ago

Sorry to say that, but team don't wanna move forward with that approach for now. But, we can't say you guys can't come up with an adapter 😉 If you know what I mean. So feel free to @sourabpramanik or @bkniffler make your own adapters.

sourabpramanik commented 2 months ago

Gotcha @ogzhanolguncu

ogzhanolguncu commented 2 months ago

If you have a working solution make sure to put it here so other people can use it.