search

upstash / ratelimit-js

Rate limiting library for serverless runtimes
https://ratelimit-with-vercel-kv.vercel.app
MIT License
1.65k stars 33 forks source link

blockUntilReady and cf workers #70

Closed bkniffler closed 4 months ago

bkniffler commented 10 months ago

blockUntilReady relies on Date.now, but in cf worker env, Date.now does not reliably progress as in nodeJS or browser env.

https://developers.cloudflare.com/workers/runtime-apis/web-standards/

Maybe this could get added to docs, it might safe a few people from headaches.

Bildschirmfoto 2023-11-20 um 15 23 04
github-actions[bot] commented 8 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

ogzhanolguncu commented 8 months ago

bump

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

bkniffler commented 6 months ago

Is this going to be addressed eventually? This is a serious concern that most users will probably not be aware of.

ogzhanolguncu commented 6 months ago

We’ll see what we can do and if we can’t find a good solution, we’ll document in our docs. Sorry for late reply.

ogzhanolguncu commented 6 months ago

Issue is finally addressed here in the docs: https://github.com/upstash/docs/pull/121

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 4 months ago

This issue was closed because it has been stalled for 30 days with no activity.