docs: fix `@default` JSDoc comment for `analytics` config

upstash / ratelimit-js

Rate limiting library for serverless runtimes

https://ratelimit-with-vercel-kv.vercel.app

MIT License

1.65k stars 33 forks source link

docs: fix `@default` JSDoc comment for `analytics` config #90

Closed unstubbable closed 6 months ago

unstubbable commented 6 months ago

Syncing this with: https://github.com/upstash/ratelimit/blob/3c3818daade86a2fa294cb4785535ecd981d706d/src/ratelimit.ts#L63

Potential follow-up: Maybe the three types RatelimitConfig, RegionRatelimitConfig, and MultiRegionRatelimitConfig should share a base config type that contains the common properties (prefix, ephemeralCache, timeout, and analytics).

vercel[bot] commented 6 months ago

@unstubbable is attempting to deploy a commit to the Upstash Team on Vercel.

A member of the Team first needs to authorize it.

ogzhanolguncu commented 6 months ago

Thanks. I'll discuss the shared config option with the team.