upstash / redis-js

HTTP based Redis Client for Serverless and Edge Functions
https://docs.upstash.com/redis
MIT License
698 stars 56 forks source link

Replace throw on missing env with warning #1311

Closed CahidArda closed 1 month ago

CahidArda commented 1 month ago

Previously, we threw when the env variables were missing. This is usually fine, but in turbo we had to add the Upstash Redis env variables to turbo.json (under build.env).

This is not ideal. Instead, we now check at runtime when the request is being sent. If the credentials are missing, we throw.

linear[bot] commented 1 month ago

DX-1333 turbo repo - upstash sdk test

CahidArda commented 1 month ago

doesn't work as expected with Turbo & Vercel. More info available at Linear.

CahidArda commented 1 month ago

Turbo repo was deployed when I replaced throws with warnings altogether