search

upstash / redis-py

HTTP based Python Redis Client for Serverless and Edge Functions
https://docs.upstash.com/redis
MIT License
29 stars 3 forks source link

Parameter naming changes #15

Closed burak-upstash closed 1 year ago

burak-upstash commented 1 year ago

closes #11

burak-upstash commented 1 year ago

@TudorZgimbau thanks for the review, I removed the comments like "DONE" (had some internet problems, couldn't push :))

About the parameter names like any, yes, you might be right. It doesn't seem to cause an issue, but still it would be more intuitive to keep the existing namings for those. Are there any others you noticed except any, type, min, max that I should convert back?

burak-upstash commented 1 year ago

Once everything is okay, I will run black for formatting as well

TudorZgimbau commented 1 year ago

I noticed too there seem to be no issues regarding the shadowing, but as you said it might be more intuitive to keep the current namings, and also, I would avoid playing with reserved keywords as parameters.

Other than those, I think only match, which was added in 3.10 to have some sort of switch statement.

burak-upstash commented 1 year ago

@TudorZgimbau changed reserved keywords and ran black formatter. Can you have a quick look please?

TudorZgimbau commented 1 year ago

SGTM, thank you very much. I'll merge this now, but please add a note to the README about using black and any other tool you think would be a great addition.

burak-upstash commented 1 year ago

Yes, I will update the README after we finalize the version. I will also define some workflows, I will also update relevant data once I get to that

TudorZgimbau commented 1 year ago

Great, thanks!