EVAL was breaking when trying to run without keys, and our tests didn't catch that.
In addition to what I've already stated in https://github.com/upstash/redis-python/pull/16, we should have a test that doesn't rely on any optional parameter, and all the tests should be typed as returning None.
From now on, let's not make any more concessions when it comes to testing 😅.
EVALwas breaking when trying to run without keys, and our tests didn't catch that.In addition to what I've already stated in https://github.com/upstash/redis-python/pull/16, we should have a test that doesn't rely on any optional parameter, and all the tests should be typed as returning None.
From now on, let's not make any more concessions when it comes to testing 😅.
Edit: I've also ran
black.