upstash / redis-py

HTTP based Python Redis Client for Serverless and Edge Functions

https://docs.upstash.com/redis

MIT License

29 stars 3 forks source link

Do not expose the fields of the clients #28

Closed mdumandag closed 1 year ago

mdumandag commented 1 year ago

We should keep the public API surface as minimal as possible. I don't see the benefit of making the configuration related fields of the client public. Hence, I converted all of them to protected fields.

I have also updated the README in couple of places. I have removed the part where we mention you could have per-command-formatting configuration: It is a pretty bad idea to allow mutable state on the client object.

burak-upstash commented 1 year ago

26 is merged, this pr can be rebased

mdumandag commented 1 year ago

I will do it after merging the mypy pr, as this depends on that as well