upstreammuse / cashpiles

0 stars 0 forks source link

Extra deferral markers added during reconciliation #34

Open upstreammuse opened 2 years ago

upstreammuse commented 2 years ago

Reconcile was adding extra deferral markers to things that were already deferred.

Expected Cause: Items that were already deferred were not being hidden from the reconcile dialog, so they picked up another deferral when they weren't selected in the dialog list.

Should items that are deferred w.r.t. the current reconciliation attempt be hidden from the dialog? Might cause confusion?

Since GUI reconciliation is always 'unreconciled' -> 'latest reconcile', perhaps the deferral count can be set to 1 vs. incremented?

I think we should just hide deferred items from the reconcile dialog. If the user is just using the GUI, they won't get into trouble, because they'll always be deferring one more tick, and never have an item with 'too many' deferrals on it.