search

upta / pubsub

An extremely light-weight, easy to use PCL pub/sub library
Apache License 2.0
219 stars 53 forks source link

Updated pubsub to .net standard 1.5 #11

Closed Macjon closed 7 years ago

Macjon commented 7 years ago

I've updated the project to .net standard 1.5.

upta commented 7 years ago

Looks like the formatting in the hub class got jacked up; if there aren't any significant changes to it, maybe just roll back the changes to that file. Otherwise, not opposed to merging, thanks!

Macjon commented 7 years ago

There is one change at line 43 of the Hub.cs file.

upta commented 7 years ago

I pulled down this branch locally and (in VS 2017 at least, haven't tried elsewhere) the tests won't run. Possible that something needs to be updated in that project as well?

dazinator commented 7 years ago

I have fixed this up here: https://github.com/dazinator/pubsub/tree/netstandard All tests pass in vs2017

I also reduced it to netstandard1.1 for greater compat. Tests project upgraded to net46, and using the newer mstest nuget packages.

dazinator commented 7 years ago

I'll need to add some attributes to the project control the nuspec that is produced when you do a Pack and then I will delete the nuspec.

upta commented 7 years ago

@dazinator Great! If you want to just submit yours as another PR when you're done I'll be happy to merge that one instead.

dazinator commented 7 years ago

PR Submitted.