uptake / autofocus

Deep learning computer vision for classifying wildlife in camera trap images
BSD 3-Clause "New" or "Revised" License
54 stars 30 forks source link

Allow capitalized extensions, add basic tests #103

Closed gsganden closed 5 years ago

gsganden commented 5 years ago

Currently the app only accepts files with extensions in ["png", "jpg", "jpeg", "gif", "bmp"]. Sometimes these extensions are capitalized; in particular, a lot of camera traps datasets have files with the extension "JPG". This PR addresses that problem by casting the extension checking whether the extension is in the allowed set after casting it to lowercase.

But wait, there's more. This PR adds not one, not three, but TWO tests. [Edit: Actually now it adds three tests.] These tests depend on the app being up, so I don't know a good way to run them on Travis. I set up a structure to separate these "app tests" from "package tests" and run only the "package tests" on Travis.

Closes #66

Pull Request Checklist

Maintainer's responsibilities: