Clean up app code - Githubissues

uptake / autofocus

Deep learning computer vision for classifying wildlife in camera trap images

BSD 3-Clause "New" or "Revised" License

54 stars 30 forks source link

Clean up app code #104

Open gsganden opened 5 years ago

gsganden commented 5 years ago

The code in autofocus/predict works, but it was written in a hurry and would probably benefit from some careful attention.

DigitalPhilosopher commented 5 years ago

Hey, I have tried to clean up and organize the code in predict. I would like to open a new branch and push to it, but it seems that I do not have the permission to do that.

I've also managed to find and close some bugs:

The zip is removed from the server after completion
The complete zip is now analyzed (before it returned within the loop)

gsganden commented 5 years ago

Awesome!

Sorry, the PR process needs a bit of cleanup and documentation. Please create a fork and submit your PR against the dev branch. LMK if you run into any issues.

DigitalPhilosopher commented 5 years ago

Perfect, thank you. I created the PR now. After a few changes the build is now running on travis.

One side note: Since there was the bug in the loop at the predict_zip endpoint, the running PR takes all files instead or running a loop. I think the better solution here would be to add a method in ZipFile named apply, which can apply a method on all the files in the zip file.